suckless/slstatus

wifi_essid: add boundary check && prevent the use of direct string literal as a format string in snprintf() (94e87eb8baaf1c20d02602ba3d01bc1babdb2e35)
Repositories | README | LICENSE
commit 94e87eb8baaf1c20d02602ba3d01bc1babdb2e35
parent 11fec4fa9501bd20aace72235c4525dc87d5d281
Author: raiz <[email protected]>
Date:   Tue, 27 Dec 2016 20:14:45 +0300

wifi_essid: add boundary check && prevent the use of direct string literal as a format string in snprintf()

Diffstat:

Mslstatus.c3++-


1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/slstatus.c b/slstatus.c
@@ -717,7 +717,8 @@ wifi_essid(const char *iface)

 
 	memset(&wreq, 0, sizeof(struct iwreq));
 	wreq.u.essid.length = IW_ESSID_MAX_SIZE+1;
-	sprintf(wreq.ifr_name, iface);
+	snprintf(wreq.ifr_name, ifrn_name, "%s", iface);
+
 	if (sockfd == -1) {
 		warn("Failed to get ESSID for interface %s", iface);
 		return smprintf("%s", UNKNOWN_STR);